dmulloy2 / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
1.04k stars 257 forks source link

1.20.2 - `STEER_VEHICLE` mapped to `ServerboundPongPacket` #2818

Open LoneDev6 opened 8 months ago

LoneDev6 commented 8 months ago

Describe the bug Seems a bug of ProtocolLib 5.2.0-SNAPSHOT-679 and 1.20.2. For some reason PacketType.Play.Client.STEER_VEHICLE.getPacketClass() returns ServerboundPongPacket instead of PacketPlayInSteerVehicle. image

To Reproduce Steps to reproduce the behavior:

        ProtocolLibrary.getProtocolManager().addPacketListener(new PacketAdapter(
                PacketAdapter.params()
                        .plugin(plugin)
                        .listenerPriority(ListenerPriority.HIGHEST)
                        .types(PacketType.Play.Client.STEER_VEHICLE)
        )
        {
            @Override
            public void onPacketReceiving(PacketEvent e)
            {
                if (e.isCancelled() || e.isPlayerTemporary())
                    return;

                Player player = e.getPlayer();
//.....

Expected behavior STEER_VEHICLE to be called

Screenshots

Version Info https://pastebin.com/uwgzyVQK

jamydariels commented 6 months ago

please fix

LoneDev6 commented 5 months ago

Any news?

dmulloy2 commented 5 months ago

will take a look today

jamydariels commented 5 months ago

i'm using build 689 and i think it is fixed