Open SlimeDog opened 2 months ago
Funny, just tested it on my server and working.
You are sure you didn't have this plugin twice inside the plugin folder (and any subfolder) ?
Funny, just tested it on my server and working.
You are sure you didn't have this plugin twice inside the plugin folder (and any subfolder) ?
There was only one ProtocoLib JAR, but I had renamed it to ProtocolLib-5.2.1-b689
. Renaming had not previously been a problem, with ProtocolLib or any other plugin. I reverted to ProtocolLib-5.2.1-SNAPSHOT-689.jar
, and I'm happy to report that it works now.
I don't understand why ProtocolLib (unlike any other plugin, or ProtocolLib itself, previously) complains about JAR renaming.
Yeah, I can confirm this behavior (although I use the one on Jenkins, which is simply named "ProtocolLib.jar"). I, as usual, I rename it "ProtocolLib-bXXX.jar", it state that it can't load the "bXXX" plugin, but ProtocolLib is still loading fine in my case.
I renamed it to ProtocolLib(B689).jar -> no complains ... strange..
Try with a dash "-", maybe that's just a little bug :D (Tested on Paper)
Try with a dash "-", maybe that's just a little bug :D (Tested on Paper)
Yes, "ProtocolLib_(B689).jar" -> no issue ProtocolLib-(B689).jar -> has that issue (using Paper, while Spigot is OK)
I have encountered this issue only with the current ProtocolLib, of the 160+ plugins I test. For consistency, I modify the JAR filenames of at least half of them -- any filename that contains -SNAPSHOT
or -DEV
or similar; add b
before the build number for those that don't do so; and add the build number for those that don't do so, even though they are development builds.
yeah so there's some checks on startup where it tries to parse the minecraft version of the file name if it contains a -
. immediate fix is to remove that and just name it ProtocolLib.jar. i'll look into removing/fixing that behavior. it's been in for a few years and i don't remember the context of why we added it anymore
Since the check produces an incorrect version assessment and plugin disable, fixing it seems advisable.
The current PluginRemapper behavior is too intrusive #10649 I do not know Paper it is for what purpose, set such a folder.
Describe the bug Failure to load ProtocolLib on Paper 1.20.6 after changing JAR filename. No other plugins.
To Reproduce Steps to reproduce the behavior:
Expected behavior Accept renamed JAR file
Screenshots
Version Info Provide your ProtocolLib install info with
/protocol dump
through pastebin.(
protocol dump
produces a stack trace)Additional context