search

dmulloy2 / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
1.02k stars 259 forks source link

Holograms messed up #2948

Open KenterWasTaken opened 3 months ago

KenterWasTaken commented 3 months ago

Describe the bug I use decent holograms and citizens on my server both on latest compatible versions, my server is running on 1.20.4 paper, and when I download protocollib and restart the server, some holograms have visible armor stands on them and some npcs (citizens) are gone and their holograms are reversed with some others, that's what happens just from downloading this plugin, is there a way to fix this, because I need it for a lot of stuff I want to add.

To Reproduce Steps to reproduce the behavior: I don't really understand this, I really just installed the plugin and it started happening.

Expected behavior Well, since it's just a dependancy for a lot of plugins, I kinda just want it to sit around and act as the dependency it is, and not disrupting my other plugins.

Screenshots None

Version Info Latest, sorry not on PC right now but I can send that later if if possible

Additional context None

KenterWasTaken commented 3 months ago

It isn't fixed yet!!!

Jeppa commented 3 months ago

'Latest' is not a version... Are there any errors in console?

KenterWasTaken commented 3 months ago

@Jeppa no errors in the console.. if only it was that simple, and how is latest not a version, well if you want to be specific it's 5.2.0 the latest I believe, it's the only one that works on 1.20.4 anyway

Jeppa commented 3 months ago

So you're on 'latest' from the project's page which is build 679. Maybe try dev build 689 . My 1.20.4 server is running decent holograms (2.8.6) and protocollib (build 678) without any issues. PS: I just have a few holograms btw. ...

KenterWasTaken commented 3 months ago

@Jeppa I'm only seeing versions such as 5.2.0, 5.1.0, and below, where are those dev builds?

Jeppa commented 3 months ago

here https://ci.dmulloy2.net/job/ProtocolLib/ (see the Resources links on ProtocolLib's Github page (ReadMe))

KenterWasTaken commented 3 months ago

@Jeppa 689 (latest) does the same thing.. and I can't see lower than like 685 I think, what should I do? That problem is probably caused by the new versions.

KenterWasTaken commented 3 months ago

@Jeppa you there

KenterWasTaken commented 3 months ago

Still NOT fixed!!!!

Jeppa commented 3 months ago

@Jeppa 689 (latest) does the same thing.. and I can't see lower than like 685 I think, what should I do? That problem is probably caused by the new versions.

Tested with paper/purpur 1.20.4 and DecentHolograms 2.8.8 with ProtocolLib build 689 --> no issues here! I'm not running 'citizens' on my server.

KenterWasTaken commented 3 months ago

Weird, maybe it's caused by a third-party plugin?

Jeppa commented 3 months ago

Try to run the server without Citizens and see what happens. btw: what are the versions of citizens and DecentHolograms you are using?

KenterWasTaken commented 3 months ago

@Jeppa I tried that, definitely not citizens causing the issue, everything was the same except well the npcs. Citizens version: 2.0.33-b3382 I use decentholograms on version 2.8.8, and it's probably not caused by dh either

KenterWasTaken commented 3 months ago

Okay I tried removing dh from my server and the armor stands aren't caused by the holograms, they are caused by the crates, then the holograms switch with others, and the npcs dissapear and their holograms switch with others too. So it's actually causing problems to not 2 but 3 of my plugins, maybe even more that I'm not aware of.

Jeppa commented 3 months ago

Mabe try this: you can change the config in Citizens and disable hooking into ProtocolLib: set general.interop.protocollib to false and see if this has any effect...

KenterWasTaken commented 3 months ago

@Jeppa alright that could really work, could I do that with the other plugins too?

Jeppa commented 3 months ago

If they have a similar feature...