search

dmulloy2 / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
982 stars 259 forks source link

ProtocolLib breaks LibsDisguises. #2998

Closed andrewkm closed 2 weeks ago

andrewkm commented 2 weeks ago

Paper 1.20.4 Build 497 (https://github.com/PaperMC/Paper/commit/d8d54d927974f36ab1f919c808c0ed9e67e0e6f0) LibsDisguise compiled against https://github.com/libraryaddict/LibsDisguises/commit/ed2a33f7035fd84a865ae45b45fbe1d541138bab Protocollib latest compiled against https://github.com/dmulloy2/ProtocolLib/commit/8272ecb33d7a0197ca9c96037cf1d95ca3dd603f

Error on initializing: https://pastebin.com/raw/3JxxYsBk

I've tracked the ProtocolLib issues to one of the following builds: https://github.com/dmulloy2/ProtocolLib/commit/f0468e04d99c1acd7b2004cab5919b4fa275cce5 https://github.com/dmulloy2/ProtocolLib/commit/76432f9d3674b1186674af0081e38d2e04a053ea (a change made 10 minutes later)

Unfortunately my jenkins pings every 10 minutes, so those two commits slipped into one build.

Was told by developer this is a ProtocolLib issue.

andrewkm commented 2 weeks ago

@dmulloy2 This has fixed initialization, however I continue to get errors on using the /disguise command for example which all seem to relate to ProtocolLib:

https://pastebin.com/raw/BTfXUwq8

Can you possibly re-open?

andrewkm commented 2 weeks ago

I continue to get https://pastebin.com/raw/XiFJ6hpi, even after https://github.com/dmulloy2/ProtocolLib/commit/4051caca0b4ab447fe60603ad51667f12eea294a.

andrewkm commented 2 weeks ago

Confirming all looks good as of https://github.com/libraryaddict/LibsDisguises/commit/ed2a33f7035fd84a865ae45b45fbe1d541138bab & https://github.com/dmulloy2/ProtocolLib/commit/389233f599b6d0008e607f8c498bfb152a130424 via Paper 1.20.4.