search

dmuneras / moodle-theme_archaius

Moodle theme
5 stars 9 forks source link

Tab issues (gradebook and quiz) #22

Open vaughany opened 10 years ago

vaughany commented 10 years ago

Hi Daniel, sorry to raise another issue so quickly, but to tell you the truth, we have only just noticed this one.

Tabs, as used in the gradebook and elsewhere in Moodle, have padding, border and background colour problems. We're using Moodle 2.7.1. and this is reproducible with a fresh install of Moodle 2.7 and a fresh install of the Archaius theme (master branch) although I had to change a gradebook setting to turn on tabs, which is not default but it is how we run our live / production Moodles.

This first image shows gradebook tabs. As you can see, the tab 'boxes' have borders around them and a background colour set (grey on non-active tabs), as well as too much left/right padding (the tabs should be closer together). The second row has white boxes around the text, which should possibly be transparent, and the active tab ("grade report") seems to tall also. 1-gradebook

This second image, showing tabs in use when editing a quiz, serves to show that the issue is not limited to the gradebook: 2-quiz-editing

As before, I'll endeavour to look into these issues myself as time permits.

Regards.

dmuneras commented 10 years ago

Hi @vaughany

No problem. feel free to report all you consider important, if you find good solutions, feel free to propose designs (code, images, etc).

It is great you are reporting all of this issues. Because my company offers Open Online Courses, we don't use gradebook component, all grades are calculated automatically. Because of that, I haven't fully tested this part of Moodle.

I will add to my to do list a task like: "Redesigning gradebook".

Just to clarify, is it working as expected but is ugly? or is it not working?

Best regards, Daniel.

vaughany commented 10 years ago

Hi Daniel. Everything is working as expected, but ugly. :)

dmuneras commented 10 years ago

Hi @vaughany

I took a look on my development website and it looks like this:

screen shot 2014-09-14 at 12 19 26 am

Maybe I changed it after the last release.

Anyway, I seems ugly for me, so I will try to make it looks better. Regards, Daniel.

vaughany commented 10 years ago

That's really odd. I can't think what might be causing the differences. As a test, I installed a fresh copy of Moodle 2.7 from their master branch (2.7.2+ build 20140911), installed it and turned on tabs and static name column, then installed Archaius from the master branch (version 2014081300) and purged all caches, and this is the result (on Chrome for Ubuntu, and the same in Firefox for Ubuntu): new-archaius

Edit: I also turned on custom menus ("Moodle Community" and such) to match your screenshot, but nothing changed.