search

dmunozv04 / iSponsorBlockTV

SponsorBlock client for all YouTube TV clients.
GNU General Public License v3.0
2.17k stars 89 forks source link

Refactor CLI setup script, add prompts for muting and skipping native youtube ads #150

Closed ryankupk closed 2 weeks ago

ryankupk commented 2 months ago

RE: #149 - the CLI setup wizard only sets the skip_ads and mute_ads config options to false and does not give any option to set them to true during the setup process. This change adds some minor refactorings for some things in the script like using a bespoke function for prompting the user for y/n, as well as adds prompts for skipping/muting native ads and saves the choice to the config.

dmunozv04 commented 2 months ago

Thanks for the contribution to bring feature parity between both config editors! I'll make sure to review it when I have time

ryankupk commented 2 months ago

Thanks @dmunozv04. I'm not married to any line here, and I know that pulling the strings out to constants can be controversial. I'm open to any feedback.

I also saw that github is reporting every line as different but locally the git diff is a lot cleaner. I'm not sure if maybe it's a linefeed thing, I don't think that it's tab width or anything like that. I can look deeper if you're concerned about that at all.

dmunozv04 commented 2 weeks ago

It does look cleaner this way. I merged new changes into the branch

dmunozv04 commented 2 weeks ago

@ryankupk merged!