dmunozv04 / iSponsorBlockTV

SponsorBlock client for all YouTube TV clients.
GNU General Public License v3.0
2.5k stars 106 forks source link

Autoplay of TV queu is enabled regardless of config #192

Open Thomahawkuru opened 2 months ago

Thomahawkuru commented 2 months ago

Before we begin, i am aware of #82 and #190. But somehow autoplay is always enabled regardless of the config on 2.1.0.

To Reproduce Steps to reproduce the behavior:

  1. Disable autoplay in both Android youtube APP and cast device youtube APP settings
  2. Connect phone to cast device and play a video.
  3. Disable 'autoplay' toggle in TV queu on phone.
  4. Run iSponsorblockTV config main_tui.py
  5. Connect to cast devices using the manual link code method, and disable autoplay config setting.
  6. Save config and run iSponsorblockTV main.py
  7. Observe TV queu autoplay toggle being turned on automatically (and unable to toggle off while iSponsorblockTV is running)
  8. Video's are autoplayed on the castdevice.

Expected behavior TV queu autoplay behavior following autoplay setting of the config.

iSponsorBlockTV server (please complete the following information):

dmunozv04 commented 2 months ago

Please post your config (making sure to redact sensitive info). Also, calling main_tui.py sets the data_dir to a different place that what the regular program does; try opening the configurator by using main.py --setup

Thomahawkuru commented 2 months ago

Thanks for getting back quickly. Can confirm that running main.py --setup, the autoplay config is applied correctly. So seems like i was wrong in using main_tui.py to set config for main.py? Are these unrelated?

main_tui.py puts the config in home/data/config.json/config.json:

{ "devices": [ { "screen_id": "{redacted}", "name": "Platte TV", "offset": 0 }, { "screen_id": "{redacted}", "name": "TV kast", "offset": 0 } ], "apikey": "{redacted}", "skip_categories": [ "sponsor", "selfpromo" ], "channel_whitelist": [], "skip_count_tracking": true, "mute_ads": false, "skip_ads": false, "auto_play": false }

However cant find where main.py --config puts the config.json.

dmunozv04 commented 2 months ago

@Thomahawkuru You're welcome. main_tui.py was used for testing and should probably be removed, and it just forces the config dir to data. The main script will save your config.json on user_data_dir("iSponsorBlockTV", "dmunozv04") from appdirs. Maybe another command to view the data_dir path could be useful

Thomahawkuru commented 2 months ago

Thank you for clarifying, sorry for my confusion.

dmunozv04 commented 2 months ago

Don't worry, this gives me the opportunity to make it better and more clear in the future