dmunozv04 / iSponsorBlockTV

SponsorBlock client for all YouTube TV clients.
GNU General Public License v3.0
2.42k stars 98 forks source link

GUI setup terminal colors #61

Closed nol166 closed 11 months ago

nol166 commented 12 months ago

Steps to reproduce the behavior:

  1. Go to terminal.app in macOS
  2. Run the recommended docker command to use the GUI install

    docker run --rm -it \
    -v {my_path}:/app/data \
    ghcr.io/dmunozv04/isponsorblocktv \
    --setup
  3. See difficult to read text due to lack of 256 color support

Expected behavior GUI is visible in the default terminal in the OS without needing to enable additional colors. It looked normal when launching with iTerm2

Screenshots Screenshot 2023-10-13 at 10 02 32 PM

iSponsorBlockTV server (please complete the following information): Docker instance running on M1 Mac Mini. Version 2.0.1

Apple TV (please complete the following information): Apple TV 4k (2018ish)

Additional context I also encountered the issue with not being able to exit the setup after entering the API key. The hotkey "S" doesn't seem to work. I was able to use the config file to that it created to run the app though.

dmunozv04 commented 11 months ago

The people at textual provide this FAQ answer about textual apps looking bad on `terminal.app``, bit they shouldn’t look that bad. I’ll play with it because it might have to do with some env variables I set on the Dockerfile

dmunozv04 commented 11 months ago

You could also use the text-based configurator, which shouldn’t have any graphical issues

dmunozv04 commented 11 months ago

adding -e TERM=$TERM -e COLORTERM=$COLORTERM to the docker run command seems to do the trick. I'll update the wiki later

nol166 commented 11 months ago

Awesome! Ty. Small issue otherwise an amazing application

dmunozv04 commented 11 months ago

Thanks! (wiki updated)