search

dmurdoch / rgl

rgl is a 3D visualization system based on OpenGL. It provides a medium to high level interface for use in R, currently modelled on classic R graphics, with extensions to allow for interaction.
https://dmurdoch.github.io/rgl/
GNU General Public License v2.0
85 stars 20 forks source link

Sync parameter names in implementation & declaration #337

Closed MichaelChirico closed 1 year ago

MichaelChirico commented 1 year ago

e.g. for AxisInfo::AxisInfo:

https://github.com/dmurdoch/rgl/blob/ae9f14d6307ebf9dd2857d6bde2dd26f8aef2f81/src/BBoxDeco.cpp#L135

https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html

MichaelChirico commented 1 year ago

Closing this one is a particularly odd choice to me. Why maintain code like this?