fix(storage): various fixes with references and api

dmurvihill / firebase-mock

Firebase mock library for writing unit tests

55 stars 20 forks source link

fix(storage): various fixes with references and api #33

Closed dmurvihill closed 4 years ago

dmurvihill commented 4 years ago

Reopening the original PR in the new repo

dmurvihill commented 4 years ago

Really sorry I screwed up your name, Tomas... :(

dmurvihill commented 4 years ago

@TomasRup, thanks for submitting these fixes.

Because peoples' tests might have been relying on the broken behavior on creating a second bucket with the same name for over a year now, I'm classifying this as a breaking change. Look for a merge and release hopefully in January. Cheers.

dmurvihill commented 4 years ago

It looks like we have one untested change, in MockStorageBucket.file() (needs to be tested the same way you tested MockStorage.bucket(). Can someone add?