search

dmurvihill / firebase-mock

Firebase mock library for writing unit tests
55 stars 21 forks source link

Typescript definitions #53

Open sceee opened 4 years ago

sceee commented 4 years ago

Thanks for the lib. Are there typescript typings available somewhere so that firebase-mock can be used in typescript projects?

dmurvihill commented 4 years ago

I'll gladly email you mine, but they are nowhere near the quality needed to merge in. I'd love to get a PR!

sceee commented 4 years ago

@dmurvihill thanks, that'll be great, maybe we'll get them together to a state ready for a PR. Would it make sense to commit them to a separate branch so I could propose changes to that branch if I would have additions to it?

dmurvihill commented 4 years ago

Pushed to dmurvihill:type-definitions. Have at it!

One thing that would be a must is automated tests to make sure we don't cause regressions.

sceee commented 4 years ago

@dmurvihill thank you very much, I will have a look at it. Regarding automated tests for typedefs, I have little experience so I will have to see if I can help there.

dmurvihill commented 4 years ago

Check this out: https://github.com/SamVerschueren/tsd