dmusican / Elegit

A GUI client for people who want to learn Git.
MIT License
30 stars 7 forks source link

Need a 32-bit Elegit Windows build when we do releases #485

Open MikeTheGreat opened 7 years ago

MikeTheGreat commented 7 years ago

I tried running Elegit on Windows 7, on a 32 bit machine and it didn't run. When I tried I got the following error:

elegit-32bit-doesnt-run

I have run Elegit just fine on Windows 7 on my 64 bit laptop.

I'm hoping that this is a simple thing to fix. Hopefully something like "Oh, sure - we'll just change some compiler settings in IntelliJ and we can build a 32 bit version no problem". :)

dmusican commented 7 years ago

Looks like this is a challenge for the build system we're using, short of building it again on a 32-bit Windows install. A workaround appears to be here:

https://github.com/javafx-maven-plugin/javafx-maven-plugin/issues/81

I'll give that a whirl when I can.

MikeTheGreat commented 7 years ago

Thank you for looking at this incredibly quickly! :)

I've put together a 32bit Win7 VM with IntelliJ + Elegit and see if I can just build it myself. I've gotten it to build and run under IntelliJ.

How do you package it up into a nice, clean, Windows 7 .EXE (+folder of associated stuff)?

dmusican commented 7 years ago

Instructions for building it is here:

https://github.com/dmusican/Elegit/blob/master/IntelliJ-Build-Instructions.md

(That's in the repo, so you'll also see it in the cloned code.)

That's a little scant, but it's the procedure we're using.

MikeTheGreat commented 7 years ago

Thanks! I’ll try it ASAP.

(“as soon as possible” may be a bit – My clean install of Windows 7 now wants to install about 206 updates, having never been updated before. On a slow VM. When it shuts down I’m hoping to try making a new VM (same HDD) with much more RAM – it’s been a while since I’ve heard my hard drive thrash like this :) )

Thanks! --Mike


Michael Panitz Senior Founding Faculty II P: 425.352.8211 | F: 425-352-8177 www.cascadia.eduhttp://www.cascadia.edu/

Due to Washington State's broad open records law most written communication to or from College employees is public record and available to the public and the media upon request. Therefore this e-mail communication may be subject to public disclosure.

From: Dave Musicant [mailto:notifications@github.com] Sent: Friday, March 17, 2017 2:10 PM To: dmusican/Elegit Elegit@noreply.github.com Cc: Panitz, Michael W. mpanitz@cascadia.edu; Author author@noreply.github.com Subject: Re: [dmusican/Elegit] Elegit doesn't run on 32 bit Windows 7 (#485)

Instructions for building it is here:

https://github.com/dmusican/Elegit/blob/master/IntelliJ-Build-Instructions.md

(That's in the repo, so you'll also see it in the cloned code.)

That's a little scant, but it's the procedure we're using.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dmusican/Elegit/issues/485#issuecomment-287471930, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhqwz6j_Di5UjNY8sNtrXtlXFpuvZUUks5rmvafgaJpZM4MgJqJ.

MikeTheGreat commented 7 years ago

Ok, I finally built it, moved it over to the school computers, and then ran it there. It was really, really slow (it took a minute or two to start up) but it did run.

If you’re curious, I’ve got a .ZIP of it up at http://faculty.cascadia.edu/mpanitz/Elegit.zip

Thanks! --Mike


Michael Panitz Senior Founding Faculty II P: 425.352.8211 | F: 425-352-8177 www.cascadia.eduhttp://www.cascadia.edu/

Due to Washington State's broad open records law most written communication to or from College employees is public record and available to the public and the media upon request. Therefore this e-mail communication may be subject to public disclosure.

From: Dave Musicant [mailto:notifications@github.com] Sent: Friday, March 17, 2017 2:10 PM To: dmusican/Elegit Elegit@noreply.github.com Cc: Panitz, Michael W. mpanitz@cascadia.edu; Author author@noreply.github.com Subject: Re: [dmusican/Elegit] Elegit doesn't run on 32 bit Windows 7 (#485)

Instructions for building it is here:

https://github.com/dmusican/Elegit/blob/master/IntelliJ-Build-Instructions.md

(That's in the repo, so you'll also see it in the cloned code.)

That's a little scant, but it's the procedure we're using.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dmusican/Elegit/issues/485#issuecomment-287471930, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhqwz6j_Di5UjNY8sNtrXtlXFpuvZUUks5rmvafgaJpZM4MgJqJ.

MikeTheGreat commented 7 years ago

A minute or two seemed odd, so I went back and re-ran it. It took 15(-ish) seconds to start up the first time, and 7 the second and third time. That’s a totally reasonable time for students on a shared system.

Either I wasn’t timing it closely enough (i.e., I wandered off and then noticed it was done a minute or two later) or maybe the server was bogged down with something else (the quarter ended on Friday so IT may be doing updates).

Anyways, I’ll try to remember to check it again before I roll it out, but it’s definitely reasonable, start-up-time-wise.

Thanks! --Mike


Michael Panitz Senior Founding Faculty II P: 425.352.8211 | F: 425-352-8177 www.cascadia.eduhttp://www.cascadia.edu/

Due to Washington State's broad open records law most written communication to or from College employees is public record and available to the public and the media upon request. Therefore this e-mail communication may be subject to public disclosure.

From: Panitz, Michael W. Sent: Saturday, March 18, 2017 12:54 AM To: 'dmusican/Elegit' reply@reply.github.com; dmusican/Elegit Elegit@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [dmusican/Elegit] Elegit doesn't run on 32 bit Windows 7 (#485)

Ok, I finally built it, moved it over to the school computers, and then ran it there. It was really, really slow (it took a minute or two to start up) but it did run.

If you’re curious, I’ve got a .ZIP of it up at http://faculty.cascadia.edu/mpanitz/Elegit.zip

Thanks! --Mike


Michael Panitz Senior Founding Faculty II P: 425.352.8211 | F: 425-352-8177 www.cascadia.eduhttp://www.cascadia.edu/

Due to Washington State's broad open records law most written communication to or from College employees is public record and available to the public and the media upon request. Therefore this e-mail communication may be subject to public disclosure.

From: Dave Musicant [mailto:notifications@github.com] Sent: Friday, March 17, 2017 2:10 PM To: dmusican/Elegit Elegit@noreply.github.com<mailto:Elegit@noreply.github.com> Cc: Panitz, Michael W. mpanitz@cascadia.edu<mailto:mpanitz@cascadia.edu>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [dmusican/Elegit] Elegit doesn't run on 32 bit Windows 7 (#485)

Instructions for building it is here:

https://github.com/dmusican/Elegit/blob/master/IntelliJ-Build-Instructions.md

(That's in the repo, so you'll also see it in the cloned code.)

That's a little scant, but it's the procedure we're using.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dmusican/Elegit/issues/485#issuecomment-287471930, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhqwz6j_Di5UjNY8sNtrXtlXFpuvZUUks5rmvafgaJpZM4MgJqJ.

dmusican commented 7 years ago

Glad to hear it started up faster. Shared systems, anti-virus checking, and all that jazz can have a pretty negative effect on startup times, especially on Java applications. That said, if Elegit is significantly worse than another Java app (meaning we might actually be able to do something about it, we'd want to know). I've been using VisualVM to profile which methods take dramatic amounts of time. If you continue to see startup issues, and would be able to profile yourself with VisualVM to see where the time is going, that would be useful.

It sounds like you've got your problem taken care of for now, but I'm going to leave this issue open as an indicator that we need to get a 32-bit Windows build as part of our regular process.

FibreFoX commented 7 years ago

This is a known limitation of the JDK

https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html#JSDPG586

Package per target platform

Self-contained application packages are platform-specific and can only be produced for the same system on which you build. To deliver self-contained application packages on Windows, Linux, and OS X, you must build your project on all three platforms.

Cross-creation is not supported, the JDK-bug got closed as "wont fix": https://bugs.openjdk.java.net/browse/JDK-8091056

To me there is currently no working workaround known.

dmusican commented 7 years ago

Thanks, @FibreFoX. I'll leave this issue open as a reminder that our release process needs to include building a 32-bit build.