dmusican / Elegit

A GUI client for people who want to learn Git.
MIT License
30 stars 7 forks source link

Verify that remote repos unsubscribe correctly in RepositoryMonitor #561

Open dmusican opened 6 years ago

dmusican commented 6 years ago

Whenever a new repo is opened, SessionModel maintains a PublishSubject called openedRepos whose job is to make sure RepositoryMonitor is watching the remote on that repo. When the repo is closed (or removed from Elegit? think this through), I'm not sure if we're unwatching that in any kind of reasonable way. Think through what should happen here, write a test, and make sure resources are appropriately being freed up.