search

dmusican / Elegit

A GUI client for people who want to learn Git.
MIT License
30 stars 7 forks source link

CommitLabelFXTest and SshPrivateKeyPasswordExistingFXTest fail inconsistently #621

Open grenche opened 6 years ago

grenche commented 6 years ago

These two tests seem to fail inconsistently which makes me think they are probably related to threading errors.

grenche commented 6 years ago

We think the issue in SshPrivateKeyPassworkExistingFXTest (and sometimes CloneSshFXTest in the commandLine folder) have to do with the fact that the ssh server is shut down before the thread is done running for repo monitor (documented in test as well). This is likely just a test bug, but a better solution would be good.

CommitLabelFXTest might be failing at the testAddFileAndCommit() -> doGitStatusWhenSubscribed() -> updateAllBranches -> refreshHeadIds -> refreshHeadIdsType() -> getHeadId() when getCommit() is called, but that hasn't been confirmed.