search

dmwm / CRABClient

runrange
14 stars 35 forks source link

clean up code that uses Emulator/getDefault returned dictionary #5104

Open ddaina opened 2 years ago

ddaina commented 2 years ago

find and remove all the places where ufc key from Emulator/getDefault returned dictionary is used. currently it returns dummy value: https://github.com/dmwm/CRABClient/blob/master/src/python/CRABClient/Emulator.py#L29

belforte commented 2 years ago

I think this was done in #5115 Shall we remove the ufc key from Emulator.py and verify that nothing is broken ? I never touched this becasue I never understood how this Emulator is working, but I suspect that we could simply get rid of it and directly instantiate CRABRest where needed. I do not see much use case for using a complicated way to insert some different REST interface to test.

ddaina commented 2 years ago

I think this was done in #5115

I think you are right

Shall we remove the ufc key from Emulator.py and verify that nothing is broken ?

I will test it report results here, unless you are already doing it

belforte commented 2 years ago

no. I was not doing it. Please test, thanks.