dmwm / CRABClient

runrange
14 stars 36 forks source link

Print all Publish Containers in crab status command #5274

Open novicecpp opened 9 months ago

novicecpp commented 9 months ago

crab status command in latest version only print Publish Container that have the same name as tm_output_dataset.

Screenshot from 2023-12-14 17-26-33

Now that we have multiple Publish Containers, we need to display all of them. The info to display is already there in taskdb tm_multipub_rule.

novicecpp commented 9 months ago

My proposal is print them when supply the --long arg.

The new version of crab status without --long (notice the Publish container's rule is gone): Screenshot from 2023-12-14 17-24-08

with --long, it will print Publish Container's name and its rule after Publication section: Screenshot from 2023-12-14 17-23-47

@belforte What do you think?

belforte commented 9 months ago

I'd rather add a new option than expect/ask users to use --long with task of >100 jobs. But.. are we talking about one line for each output file ? I.e. mostly one at at most a handful ? Why not adding them all of the times ? I agree that the crab status output is getting long. But suggest to keep looking for ideas. Maybe add an option to list rules ? In the end rules on Publish container are not very useful, esp. if they have no expiration date. And one can simply to rucio rule-info <container>. Maybe one line about this ?

Anyhow, I would really really stay out of status --long

novicecpp commented 9 months ago

Maybe add an option to list rules ? In the end rules on Publish container are not very useful, esp. if they have no expiration date. And one can simply to rucio rule-info . Maybe one line about this ?

I don't think so. I always use the rule ID as the starting point when interact with the Rucio system, mainly because it has GUI that easy to navigate around. If it not enough, then I will go to the CLI like list-file-replicas or list-account-usage command. It also tell the users which rule is created and managed by CRAB.

.

About the --long I kinda agree with you. I personally do not mind having the longer output, and as the reason above, I still want to show both the container name and rule ID.

Maybe a new arg like --show-containers is the best option where we can keep status output short, trade-off with a little extra effort required from users to provide additional arg. We can also add more information to the output like rule expiration time or lock status summary.