search

dmwm / CRABClient

runrange
14 stars 35 forks source link

avoid `nosort` option in crab command completion #5321

Closed belforte closed 1 week ago

belforte commented 2 weeks ago

see https://cms-talk.web.cern.ch/t/crab-is-not-working/41539/12?u=belforte

IMHO there is no need for nosort and we can also remove all those weights, listing commands in alphabetical order is fine. If we want to group command and/or add a tiny online guide, we can do in crab --help not in crab <TAB>

smuzaffar commented 2 weeks ago

@belforte , I have added a CI tests to make sure one can run cmsset_default.sh (which also sources crab-bash-completion.sh for crab pre-prod, dev). Enabling this tests for existing crab/cms-common versions shows that we need fixes for zsh and el7.

I have fixed cms-common to not fail under zsh. I also have patched crab specs to drop -o nosort (which fails under el6 and el7) . cmdist PR contains these changes and new CI tests passed for bash, sh and zsh under el6 to el9.

Hopefully in future we can catch such failures during CI tests

belforte commented 2 weeks ago

Thanks a lot @smuzaffar . I am sorry that CRABClient creates problems every now and then. If you think that we could/shoud review the way it is deployed, please let us know.