search

dmwm / CRABClient

runrange
14 stars 35 forks source link

Fix autocompletion #5322

Closed belforte closed 1 week ago

belforte commented 2 weeks ago

fixes #5321 fixes #5319

cmsdmwmbot commented 2 weeks ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABClient-PR-test/1061/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 2 weeks ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABClient-PR-test/1062/artifact/artifacts/PullRequestReport.html

mapellidario commented 1 week ago

Stefano, can I ask you to run the generate_completions script and commit the new etc/crab-bash-completion.sh as well? [1]

maybe we should add this command to the specifile as well https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_14_1_X/master/crab-build.file, but if the changes are not frequent enough it may not be worth it.

[1]

> cd CRABClient
> python3 scripts/generate_completions.py

mentioned at https://github.com/dmwm/CRABClient/blob/d17ff66a143d33d99d31c8f767c3cc75fdbceef8/scripts/generate_completion.py#L13

belforte commented 1 week ago

I had tried that, but can't do it on my laptop since

LapSB:CRABClient$ python3 scripts/generate_completion.py
INFO:root:etc/crab-bash-completion.sh

Error: $CMSSW_VERSION is not defined. Make sure you do cmsenv first. Exiting...
LapSB:CRABClient$

As you were away, I forgot to ask for help and/or mention this.

I can fix this with a commit from lxplus, But... 1) it means that there's no hope to do it in crab_build 2) even including it in a future automatic pipeline for CRABClient (which Wa has in his plans) may be complicated

belforte commented 1 week ago

Done. Thanks @mapellidario for reminding me !

cmsdmwmbot commented 1 week ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABClient-PR-test/1064/artifact/artifacts/PullRequestReport.html