search

dmwm / CRABServer

15 stars 37 forks source link

Fix typos in output strings #8408

Closed oljemark closed 1 month ago

oljemark commented 1 month ago

Hello. I saw some typos in the exception and printing statements (that did not seem to be parsed elsewhere as such misspellings), which I fixed. I also noticed the misspelled JSON parameter with 3 c's here: https://github.com/dmwm/CRABServer/blob/master/src/python/CRABInterface/RESTWorkerWorkflow.py#L160 Is that intentional to not hit the exception below, or just a typo not tested with enough malformed older REST inputs? https://github.com/dmwm/CRABServer/blob/master/src/python/CRABInterface/RESTUserWorkflow.py#L433

cmsdmwmbot commented 1 month ago

Can one of the admins verify this patch?

belforte commented 1 month ago

thanks @oljemark for such a careful proofing ! As to the misspelled acccelerator with 3c's, I can't really say since all in all that was to protect us in a transient situation which is long gone. Somehow it worked. Let's no try to do too much archeology, but we should cleanup the code.

belforte commented 1 month ago

please test this

belforte commented 1 month ago

test this please

belforte commented 1 month ago

I can't get Jenkins to run pylint.. never mind