search

dmwm / CRABServer

15 stars 37 forks source link

beware extra spaces in accelerator_jdl too #8431

Closed belforte closed 1 month ago

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2000/artifact/artifacts/PullRequestReport.html

novicecpp commented 1 month ago

Do we really need this PR? Because accelerator_jdl is constructed by DagmanCreator.py

https://github.com/dmwm/CRABServer/blob/886a75271ac769a56ef7eb1bf016d649b3c4ff3a/src/python/TaskWorker/Actions/DagmanCreator.py#L507-L522

belforte commented 1 month ago

then we do not need it. My apologies for not having looked up where that is created.

novicecpp commented 1 month ago

No need to apologize and sorry for using strong word. I was wondering if you seen something that it didn't see here :-)

belforte commented 1 month ago

which strong word ? Anyhow we do not need the effort to revert this, that code will anyhow change with #8336