add env.sh scripts, monit scripts compatible with pypi containers

mapellidario commented 1 month ago

This PR

status

tested

latest images from this PR built by: https://gitlab.cern.ch/crab3/CRABServer/-/commit/7b433f3566eeda5096a7d462b0a61eb84a5324c4/pipelines

details

this PR contains the following changes

added env.sh script for crabserver, TW and publishers
the code for the env.sh script is extracted from the code inserted in start.sh. meaning that these new env.sh scripts now require -c / -g option. we can set a default in the future if we want env.sh to work without any argument
runContainer.sh required a couple of changes in if conditions for monitoring scripts to adapt to set -o pipefail

cmsdmwmbot commented 1 month ago

Jenkins results:

Python3 Pylint check: succeeded
Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2001/artifact/artifacts/PullRequestReport.html

belforte commented 1 month ago

LGTM even if I am wondering if we can unifyt the env.sh and possibly also the start.sh across the applications. Looks like thanks to the new PyPI way things have got simpler.

mapellidario commented 1 month ago

unifyt the env.sh and possibly also the start.sh across the applications

shall i have a look now in this PR, shall i look in another PR, should i leave it to wa who knows better than me which application requires what?

belforte commented 1 month ago

Let's give it to Wa/Janna as cake frosting

mapellidario commented 1 month ago

seems that we all agree on a way forward. I am merging, thanks for the reviews! :)

dmwm / CRABServer

add env.sh scripts, monit scripts compatible with pypi containers #8434

status

details