search

dmwm / CRABServer

15 stars 37 forks source link

cleanup TaskType names #8488

Open belforte opened 3 weeks ago

belforte commented 3 weeks ago

in the context of Modernize HTC calls see https://github.com/dmwm/CRABServer/issues/8337#issuecomment-2161576067

TaskType ad is defined in https://github.com/dmwm/CRABServer/blob/3c826e3856dfb602150c817b4ddf6aa8e8e4ecf2/src/python/TaskWorker/Actions/DagmanSubmitter.py#L529 and https://github.com/dmwm/CRABServer/blob/3c826e3856dfb602150c817b4ddf6aa8e8e4ecf2/src/python/TaskWorker/Actions/PreDAG.py#L338

the stage in PreDAG is passed as argument when PreDAG is called during Dag execution: https://github.com/dmwm/CRABServer/blob/3c826e3856dfb602150c817b4ddf6aa8e8e4ecf2/src/python/TaskWorker/Actions/DagmanCreator.py#L56

and the code which managed the various DAGs creation is the somehow cryptic https://github.com/dmwm/CRABServer/blob/3c826e3856dfb602150c817b4ddf6aa8e8e4ecf2/src/python/TaskWorker/Actions/DagmanCreator.py#L998-L1024

belforte commented 2 weeks ago

do not put priority very high, since in the end it is quite some work, need to changes a lot of places, for "small" gain