add /etc/condor/condor_config to TW Fix #8497

dmwm / CRABServer

15 stars 37 forks source link

add /etc/condor/condor_config to TW Fix #8497 #8499

Closed belforte closed 1 week ago

cmsdmwmbot commented 2 weeks ago

Jenkins results:

Python3 Pylint check: succeeded
Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2016/artifact/artifacts/PullRequestReport.html

belforte commented 1 week ago

thanks Wa. Sorry I had meant to explain why I asked for a review here but somehow it got lost. Of course the change in itself is a no-brainer, but I meant to let you comment on the specific way I implemented in Dockerfile. You made me worry about having too many RUN and hence too many layers and too large images. But I do not have a proper understanding.

novicecpp commented 1 week ago

You made me worry about having too many RUN and hence too many layers and too large images.

You understand it correctly. But this change is not much compare to largish pip install and gfal-* layer. One thing you need to keep in mind is, make sure that when you create new directory and copy file has proper permission you want for service, avoid chmod like I do in cicd/crabtaskworker_pypi/Dockerfile#L134