dmwm / CRABServer

15 stars 37 forks source link

Fix various CIs #8514

Closed novicecpp closed 1 week ago

novicecpp commented 1 week ago
  1. Fix error in https://gitlab.cern.ch/crab3/CRABServer/-/jobs/40238792 CI will not pull artifacts for a job if job does not specify "needs:" from job that created the artifact (I could not find the citation, but this is what I understand from working with Gitlab-CI).
  2. Move tag_monit_latest job to tagging_release stage instead of same stage as build. Avoid blocking other stage if bug arise and it would be better to let it passing validation first.
  3. Fix force release, CI code is already there (Issue: https://github.com/dmwm/CRABServer/issues/8401) but
    • Add FORCE_RELEASE variable to skip deploy and test, which is currently equivalent to SKIP_DEPLOY but more understandable.
    • Fix when we specify RELEASE_NAME, it will not suffix with -stable.
    • Fix in set_version_name job, default value of release name is the tag name.
cmsdmwmbot commented 1 week ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2026/artifact/artifacts/PullRequestReport.html

mapellidario commented 1 week ago

Everything looks perfect, thanks for the in-person explanation, and for the promise of adding how to use these new features to our documentation :) you can merge this PR anytime :)

belforte commented 1 week ago

thanks Wa and Dario. I will not try to understand the details here. There's a limit at how much I can absorb.

mapellidario commented 1 week ago

There's a limit at how much I can absorb.

I have to admit that I struggle to keep up with the implementation details, Wa's qi is getting too strong :) Nonetheless, I start to see how nice the result is, I really like interacting with gitlab and I promise and made wa promise that we will have a simple "how to use" guide. Once you start using it I am sure that you will enjoy play with it as well :)

belforte commented 1 week ago

oh I like it already. Simply can't read the YAML file and have an opinion !

novicecpp commented 1 week ago

Thanks Dario and Stefano for comments!