search

dmwm / CRABServer

15 stars 37 forks source link

Remove HTCondorUtils.py #8339 #8531

Open aspiringmind-code opened 3 days ago

aspiringmind-code commented 3 days ago

See https://github.com/dmwm/CRABServer/issues/8339

belforte commented 3 days ago

did you test this ?

cmsdmwmbot commented 3 days ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2036/artifact/artifacts/PullRequestReport.html

aspiringmind-code commented 2 days ago

REST tested locally on K8s pod

crab3@crabserver-69b4975fc7-64ns9:/data/repos/CRABServer$ git checkout vchakrav27/06/24_Issue8339 Branch 'vchakrav27/06/24_Issue8339' set up to track remote branch 'vchakrav27/06/24_Issue8339' from 'vchakrav'. Switched to a new branch 'vchakrav27/06/24_Issue8339' crab3@crabserver-69b4975fc7-64ns9:/data/repos/CRABServer$ cd /data crab3@crabserver-69b4975fc7-64ns9:/data$ ./start.sh -g -d Stop crabserver service... 97 99 Removing stale pid file /data/srv/state/crabserver/crabserver.pid [28/Jun/2024:10:28:31] INFO: final CherryPy configuration: {'engine.autoreload.on': False, 'request.methods_with_bodies': ('POST', 'PUT', 'DELETE'), 'request.show_tracebacks': False, 'server.environment': 'production', [...] [28/Jun/2024:10:32:09] RESTSQL:DlFSjowYUZIT ENTER cmsweb_crab_9r_dev@int2r CRABInterface.RESTBaseAPI.RESTBaseAPI (GET devtwo workflowdb) inuse=0 idle=1 - Podname=crabserver-69b4975fc7-64ns9 Type=cherrypylog [28/Jun/2024:10:32:09] RESTSQL:DlFSjowYUZIT (previously JLEyiCjFpzNh) connected, client: 21.5.0.0.0, server: 19.21.0.0.0, stmtcache: 50 - Podname=crabserver-69b4975fc7-64ns9 Type=cherrypylog [28/Jun/2024:10:32:09] RESTSQL:DlFSjowYUZIT ping - Podname=crabserver-69b4975fc7-64ns9 Type=cherrypylog [28/Jun/2024:10:32:09] RESTSQL:DlFSjowYUZIT check [select sysdate from dual] - Podname=crabserver-69b4975fc7-64ns9 Type=cherrypylog [28/Jun/2024:10:32:09] RESTSQL:DlFSjowYUZIT connection established - Podname=crabserver-69b4975fc7-64ns9 Type=cherrypylog [...]

belforte commented 2 days ago

IIUC that means that crabserver is started. That's good, but you should also use it :-) Changes in this PR only affect taskworker, by the way.

novicecpp commented 2 days ago

The HTCondorUtils is also inside setup.py. Please remove it too.

https://github.com/dmwm/CRABServer/blob/f37fd44274ed7fbb225036df55538bead2bb0e69/setup.py#L42

We use setup.py when run buildTWTarballs.sh here

https://github.com/dmwm/CRABServer/blob/f37fd44274ed7fbb225036df55538bead2bb0e69/cicd/crabtaskworker_pypi/buildTWTarballs.sh#L52

I am not sure why buildTWTarballs.sh did not break when I taught Vijay how to run ./start.sh -g.

aspiringmind-code commented 2 days ago

References to HTCondorUtils in setup.py removed in PR https://github.com/aspiringmind-code/CRABServer/pull/1

belforte commented 2 days ago

Vijay, to modify setup.py you can simply add a commit to this branch in your local and do a git push no need to make a PR

cmsdmwmbot commented 2 days ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2041/artifact/artifacts/PullRequestReport.html