search

dmwm / CRABServer

16 stars 38 forks source link

Adding all the rule states in getTapRecallUsage and a bug fix #8741

Closed aspiringmind-code closed 1 day ago

aspiringmind-code commented 1 month ago

Fix #8736

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2200/artifact/artifacts/PullRequestReport.html

belforte commented 1 month ago

Aside the minor comment above, there is a fundamental problem here.

I am still puzzled that code could find a sensible value for input lock while ignoring OK rules. That needs to be understood. Can you look at it, or do I need to do it ?

aspiringmind-code commented 1 month ago

I will look at it.

aspiringmind-code commented 1 month ago

@belforte The use of getTapeRecallUsage was merged by me on 17th Sept in https://github.com/dmwm/CRABServer/pull/8697 and the release we are running is that of v3.240904 (4th September). Hence the changes are not yet in production and therefore we have the correct thing from using rucioClient.get_local_account_usage in the 4th Sept version.

belforte commented 1 month ago

thanks. So may be we stick with get_local_account_usage for crab_input ? Why bother to sum all rules when we have the total with a single call ? Maybe I forgetting something ?

aspiringmind-code commented 1 month ago

We did the change to address https://github.com/dmwm/CRABServer/issues/8661 as we wanted to filter by activity=AnalysisTapeRecall instead of user, and use user argument only if provided.

belforte commented 1 month ago

thanks for fixing my confusion ! and sorry for noise.

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2204/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2205/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2206/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2207/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2208/artifact/artifacts/PullRequestReport.html

belforte commented 4 days ago

@aspiringmind-code I am a bit lost here, sorry. Are you waiting for my feedback ?

aspiringmind-code commented 4 days ago

@belforte Ah, no...this is not complete. I'll fix it and tag you for your feedback when done.

cmsdmwmbot commented 3 days ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2284/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 2 days ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2285/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 2 days ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2286/artifact/artifacts/PullRequestReport.html

aspiringmind-code commented 2 days ago

@belforte This is ready for review now. Thanks!

cmsdmwmbot commented 2 days ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2287/artifact/artifacts/PullRequestReport.html