Spelling and missing 'not' in exception message

dmwm / CRABServer

16 stars 38 forks source link

Spelling and missing 'not' in exception message #8751

Closed oljemark closed 3 weeks ago

oljemark commented 3 weeks ago

Exception message accidentally positive

cmsdmwmbot commented 3 weeks ago

Jenkins results:

Python3 Pylint check: succeeded
- 3 comments to review
Pycodestyle check: succeeded
- 37 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2223/artifact/artifacts/PullRequestReport.html

belforte commented 3 weeks ago

thanks @oljemark for spotting and fixing. I am a bit surprised that you have stumbled on the "could not expand tarball with debug files". It should "never" happen and it may point to a problem somewhere. If you have information on why it happened, or any hint that something may be wrong in the code, please feel free to share.

oljemark commented 3 weeks ago

Hi @belforte . No, I was just looking through the code changes of the last few months, I didn't see the exception triggered.

belforte commented 3 weeks ago

I see. WOW !! Thanks again for excellent review !!!!!!!!!!