search

dmwm / CRABServer

16 stars 38 forks source link

Include SendVenvFolder test in Client Configuration Validation of gitlab pipeline #8779

Closed aspiringmind-code closed 1 week ago

aspiringmind-code commented 1 week ago

Currently, Jenkins runs the SendVenvFolder test in CCV but Gitlab pipeline has it commented out as it throws an error of not finding venv folder. See here Investigate and add this test as part of the pipeline.

belforte commented 1 week ago

hmm... venv folder is created here https://github.com/dmwm/CRABServer/blob/ca67bbf5d6d5f8c2a309d5805813830d48189eb7/test/container/testingScripts/setupCRABClient.sh#L16-L18

belforte commented 1 week ago

and this test works when executed via Jenkins. DId you try to simply uncomment it ?

aspiringmind-code commented 1 week ago

@belforte Yes, in the PR I have uncommented, that's why this issue is created as it is being left out of the Cv CCV PR.

belforte commented 1 week ago

I am really curious what happens differently in the pipeline which makes it fail. Feel free to point me at logs.

belforte commented 1 week ago

so the problem is that CRABClient is not setup with that script which I quoted, but by a new one https://github.com/dmwm/CRABServer/blob/master/cicd/gitlab/setupCRABClient.sh which is not simply "the old one copied to the new directory" as I thought. But at least lacks the lines which create the venv directory.

So fix is easy. But we need to check if there are other differences.

belforte commented 1 week ago

for history: the way to find out was to "notice" the following line in https://gitlab.cern.ch/crab3/CRABServer/-/jobs/45743592/raw

+ source /home/gitlab-runner/shell/builds/sedxNxqzs/0/crab3/CRABServer/cicd/gitlab/setupCRABClient.sh
aspiringmind-code commented 1 week ago

Thanks Stefano for the quick diagnosis! Fixed in the PR Closing this issue.