Add validation test against real data

ticoann commented 6 years ago

@yuyiguo, please review

cmsdmwmbot commented 6 years ago

Jenkins results:

Unit tests: succeeded
Pylint check: failed
- 11 warnings and errors that must be fixed
- 44 comments to review
Pycodestyle check: succeeded
- 1 comments to review
Python3 compatibility checks: failed
- fails python3 compatibility test
- there are suggested fixes for newer python3 idioms

cmsdmwmbot commented 6 years ago

Jenkins results:

Unit tests: succeeded
Pylint check: failed
- 12 warnings and errors that must be fixed
- 43 comments to review
Pycodestyle check: succeeded
- 1 comments to review
Python3 compatibility checks: failed
- fails python3 compatibility test
- there are suggested fixes for newer python3 idioms

cmsdmwmbot commented 6 years ago

Jenkins results:

Unit tests: succeeded
Pylint check: failed
- 12 warnings and errors that must be fixed
- 43 comments to review
Pycodestyle check: succeeded
- 1 comments to review
Python3 compatibility checks: failed
- fails python3 compatibility test
- there are suggested fixes for newer python3 idioms

ticoann commented 6 years ago

Thanks Yuyi for the review, Sure I will add that. Also I will add time out feature you were suggesting. But probably not this week.

yuyiguo commented 6 years ago

Seangchan, I added the block print out and committed the PR. It would be nice you could add the time out feature. Thanks, Yuyi

From: Seangchan Ryu notifications@github.com Reply-To: dmwm/DBS reply@reply.github.com Date: Tuesday, August 7, 2018 at 9:25 AM To: dmwm/DBS DBS@noreply.github.com Cc: Yuyi Guo yuyi@fnal.gov, State change state_change@noreply.github.com Subject: Re: [dmwm/DBS] Add validation test against real data (#578)

Thanks Yuyi for the review, Sure I will add that. Also I will add time out feature you were suggesting. But probably not this week.

dmwm / DBS