search

dmwm / DBS

CMS Dataset Bookkeeping Service
Apache License 2.0
7 stars 21 forks source link

Add Apache2 license and notice #596

Closed amaltaro closed 5 years ago

amaltaro commented 5 years ago

After consulting CMS management, Apache version 2 is the software license we decided to apply.

cmsdmwmbot commented 5 years ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-DBS-PR-test/101/artifact/artifacts/PullRequestReport.html

amaltaro commented 5 years ago

@yuyiguo I just chatted with Eric V. and he said this is the right thing to do. We might need to add a header to every single file as well, but I'm still discussing/investigating it and if we do, then we can fix that in the future somehow.

From my side, this is good to go.

yuyiguo commented 5 years ago

@amaltaro Does the license require a header to every single file? If you think DBS client satisfies CERN's publish requirement, I have no objection to release it to pypi.

amaltaro commented 5 years ago

As far as I read, it's not really a requirement but a good practice to avoid any confusion for someone looking at the code. I think we're not adding this header to WMCore at the moment, but if I find an easy tool to automagically add the header, then we might update the files too. I didn't find many comments on this, but this discussion might be worth having a look: https://forums.dotnetfoundation.org/t/file-headers-and-copyright-statements/1276/8

For the root LICENSE file that is brought in this PR, yes, that's all that we need in terms of software licensing, as discussed with CMS management.

yuyiguo commented 5 years ago

Let me know when the code is ready to commit to github.

amaltaro commented 5 years ago

This pull request is ready already.

yuyiguo commented 5 years ago

I will take a look.

From: Alan Malta Rodrigues notifications@github.com Reply-To: dmwm/DBS reply@reply.github.com Date: Tuesday, March 5, 2019 at 10:08 AM To: dmwm/DBS DBS@noreply.github.com Cc: Yuyi Guo yuyi@fnal.gov, Mention mention@noreply.github.com Subject: Re: [dmwm/DBS] Add Apache2 license and notice (#596)

This pull request is ready already.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dmwm_DBS_pull_596-23issuecomment-2D469739086&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=8bursUuc0V63OwREQMBG2Q&m=zh53wdRiZcFItOTvrYiFzWPZm-xMegdLc81nxs1yCHo&s=jjEAHsGyn4Gvx605QfvNLdLa1zgsS-k4ORNTdLqTcZM&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABsXTsMVJo8Ka9BH7pCyfxVsQktHRwZBks5vTpZ1gaJpZM4bOLdp&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=8bursUuc0V63OwREQMBG2Q&m=zh53wdRiZcFItOTvrYiFzWPZm-xMegdLc81nxs1yCHo&s=QHzY6TUojStDf6UAgy_3b8Qys9tD-Jf_Cfp6TQ_cC6E&e=.

yuyiguo commented 5 years ago

@amaltaro Alan, the license file is under DBS. Should it be in DBS/Client? @goughes Erik, the same question: Should all the client related setup scripts be in DBS/Client in stead of DBS? Thanks, Yuyi

goughes commented 5 years ago

The license files should be at the root of the repo. That way if someone clones the repo, they immediately see the license. When the packages are created for either pycurl-client or dbs-client, the license and notice files are copied from there into the package. I think the setup files for pypi should also go at the root of the repo, similar to the original setup scripts used for the RPM builds.

amaltaro commented 5 years ago

Yiyu, please let us know if there is anything else pending before you merge this PR. Thanks

yuyiguo commented 5 years ago

@amaltaro @goughes Alan, Erik It makes sense to me that the license files and pypi setup files on the the top DBS directory as Erik explained. I'd like to see requirements.dbs_client.txt, requirements.pycurl_client.txt, setup_dbs_client.py and setup_pycurl_client.py in their own directories(client and pycurl client). As soon as these changes made, I will commit them. Sorry Erik, I missed your comment on license files. THanks, Yuyi

amaltaro commented 5 years ago

This PR has nothing to do with the pypi changes you're asking for. This one is simply adding a software license for DBS code. Can you make the same comment/request on the corresponding PR such that Erik can follow up? Thanks

yuyiguo commented 5 years ago

Sure, that is not a problem. I will copy and paste my comments. I made all the comments in this one because these two PRs are related. They need to be both in DBS in order to get DBS build correctly. I will commit them together when they both are ready.