Invalid query for files REST API and listFiles client API

[amaltaro]

@yuyiguo Yuyi, I was going to investigate some possible duplicate lumi sections in a dataset and I can't make my query to work. I tried both REST and python client APIs and I hit the same issue regarding input parameters.

My use case is, provided a dataset and a lumi list, return the files that match those parameters. When I run it, DBSServer complains that I need to specify a run_num when using lumi_list. If I do so, like in this example: https://cmsweb.cern.ch/dbs/prod/global/DBSReader/files?dataset=/TTJets_SingleLeptFromT_TuneCP5_13TeV-madgraphMLM-pythia8/RunIIAutumn18DRPremix-102X_upgrade2018_realistic_v15-v1/AODSIM&run_num=1&lumi_list=[252052,240646]

it returns: {"exception": 400, "type": "HTTPError", "message": "Run_num=1 is not a valid input."}

Same problem with the python client API. I believe the problem is that when providing a lumi_list, I actually cannot use a dataset parameter, but I need to use either block or file, correct? If so, can you then please fix the error message?

[yuyiguo]

Alan,

DBS no longer support run_num=1 search with block or dataset. If run_num=1, the query has to be limit to file level. Maybe the error message should be something like when use run_num=1, LFN is expected.

[amaltaro]

Do I understand correct that if lumi_list is provided, then run_num is required? If so, then I think the error message can be something like lumi_list and/or run_num=1 is not supported for dataset/block_name, a logical_file_name must be provided.

[vkuznet]

+1 for clarity of the message.

On 0, Alan Malta Rodrigues notifications@github.com wrote:

Do I understand correct that if lumi_list is provided, then run_num is required? If so, then I think the error message can be something like lumi_list and/or run_num=1 is not supported for dataset/block_name, a logical_file_name must be provided.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmwm/DBS/issues/598#issuecomment-469739930

[yuyiguo]

Anytime a lumi is present, a run num is required. The only thing here is the run_num=1 is not support when dataset/block is provided. It is nothing to do with the lumi list. Because without lumi this query will not run either.

From: Alan Malta Rodrigues notifications@github.com Reply-To: dmwm/DBS reply@reply.github.com Date: Tuesday, March 5, 2019 at 10:10 AM To: dmwm/DBS DBS@noreply.github.com Cc: Yuyi Guo yuyi@fnal.gov, Mention mention@noreply.github.com Subject: Re: [dmwm/DBS] Invalid query for files REST API and listFiles client API (#598)

Do I understand correct that if lumi_list is provided, then run_num is required? If so, then I think the error message can be something like lumi_list and/or run_num=1 is not supported for dataset/block_name, a logical_file_name must be provided.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dmwm_DBS_issues_598-23issuecomment-2D469739930&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=8bursUuc0V63OwREQMBG2Q&m=lFTogh4K2GRn_qdgrnnOw_veyH1M8DAbZ_-LbU4DXw0&s=ew4wck97lLj3CdkSeNCGaGx5eAY_F3zjlsANSXKuMsQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABsXTuc37v9z-2DxXqsFWS586MIy1tCqfwks5vTpb6gaJpZM4be4r6&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=8bursUuc0V63OwREQMBG2Q&m=lFTogh4K2GRn_qdgrnnOw_veyH1M8DAbZ_-LbU4DXw0&s=M_IX64YgRd3j-rT7RJcIsNFrMcRJBGNB6rQlSCEO6ug&e=.

[amaltaro]

Anytime a lumi is present, a run num is required.

this part seems to be properly reported already.

The only thing here is the run_num=1 is not support when dataset/block is provided

this is not. The error message is wrong and misleading. I'm sure you can come up with an error message better than the ones I suggested above ;)

[amaltaro]

@yuyiguo Hi Yuyi, if you agree with making the message more clear, could you please make these changes for the upcoming CMSWEB release?

[yuyiguo]

@amaltaro Alan, The may release deadline is past. I will make the change for June release.

[yuyiguo]

@amaltaro

I fixed the error messages and am closing this issue. If there is more questions on error messages, please open a new one.