search

dmwm / DBS

CMS Dataset Bookkeeping Service
Apache License 2.0
7 stars 21 forks source link

DBS unit tests contradict code logic #647

Open vkuznet opened 3 years ago

vkuznet commented 3 years ago

Yuyi, I found that the following unit tests contradict DBS code logic: test03300t, test033r, test033s, test034h, test034o. In all of them except test034h, the input parameter contains run list in a form run1-run2 (it is a range of runs but any range is a list). In DBS codebase it is prohibited here. I test034h (marked as test34h) you pass run_num=1 and code prohibit if lumis and LFN are not provided, see code here.

I suggest that you properly adjust unit tests to cover this use-cases.

yuyiguo commented 3 years ago

Valentin, I do not understand the future of DBS currently. So I will work on the essential stuff for DBS only. Can we hold your requests on DBS after we talk with Kevin? I don't see any urgent issues on DBS except for the prod and crab move out from cmsweb to cmsweb-prod. I will follow up that with the email thread. If you want to call Kevin for a meeting on DBS, please feel free to do so, Thanks, Yuyi

vkuznet commented 3 years ago

Yuyi, I do not ask for immediate actions, but I also don't want to forget found issues. Therefore I document them in tickets. I fully agree that we first should decide how to treat DBS in next data rounds and then work on open tickets (if necessary).

yuyiguo commented 3 years ago

Great, We are on the same page. I don't want to let you feel that I ignore your requests.