search

dmwm / DMWMMON

1 stars 8 forks source link

StorageInsert datasvc API: strict upload parameter #11

Open nataliaratnikova opened 9 years ago

nataliaratnikova commented 9 years ago

Documentation says: strict allow overwrite or not(0 or 1), the default is strict(1) But the real default value is 0, so the records are always overwritten. Also, current client implementation has no way to pass a value for a strict parameter, so we do not know if it actually works as expected. Need to check this and fix the documentation.

nataliaratnikova commented 9 years ago

Also the client usage help implies that the strict=1 is default, and since it is not, the -force option is useless: --force - overwrite existing entry with the same timestamp, by default this would fail

We may want to have both --force-upload and --safe-upload options, which would allow to override the default, no matter how it is set.

nataliaratnikova commented 9 years ago

Tested and confirmed: the entry with the same time stamp does gets overwritten by default.

nataliaratnikova commented 9 years ago

It looks like overwriting the entry happens only for those directories entries that were included into a new upload. The previously occurred entries still appear in the record. I think the behavior we actually want when re-uploading the record with the --force option is to remove the record (all occurrences for a given site for a given time stamp) and upload a new record. I do not see a use case for the record to be uploaded by chunks.