search

dmwm / WMArchive

Workload Archive project
4 stars 13 forks source link

Fix exitCode logic to catch next non zero and not 99999 one #265

Closed vkuznet closed 7 years ago

vkuznet commented 7 years ago

Alan, after reviewing a code I understand your point. I made one more iteration for exitCode fix. Please review PR: https://github.com/dmwm/WMArchive/pull/277 and let me know.

Please note, I must use self-contained code in this files, since they're uploaded to worker node at run time and should not depend on externals due to spark environment.

Best, Valentin.

On 0, Alan Malta Rodrigues notifications@github.com wrote:

amaltaro commented on this pull request.

@@ -51,7 +51,7 @@ def extract_stats(record, timeframe_precision="day"): acquisitionEra = output.get('acquisitionEra') if acquisitionEra is not None: break

  • if exitCode is None:
  • if exitCode is None or exitCode == '99999' or exitCode = 99999:

There is a syntax error in this fix. How about: if exitCode in (None, '99999', 99999): ?

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/dmwm/WMArchive/pull/265#pullrequestreview-11349176