dmwm / WMArchive

Workload Archive project
4 stars 13 forks source link

add more cpu performance metrics #344

Closed ticoann closed 7 years ago

ticoann commented 7 years ago

related to https://github.com/dmwm/WMCore/issues/8192

ticoann commented 7 years ago

@vkuznet, Valentin, please review

vkuznet commented 7 years ago

@ticoann , what about multicore section? So far it is empty dict.

ticoann commented 7 years ago

As far as I know I don't think it passes multicore in fwjr. Also multicore is values related to Threads and Stream. (at least in the code) https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMRuntime/Scripts/SetupCMSSWPset.py#L718

But @ericvaandering, Eric would know better.

ericvaandering commented 7 years ago

Since CMSSW is putting the threads and streams in the CPU performance section, it seems wise to me to keep it there for us even if we had a placeholder for it elsewhere. Maybe we can even delete the empty dict?