search

dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Proper fix for extraline in voms proxy info and add diagnostics #12084

Closed belforte closed 2 months ago

belforte commented 2 months ago

Fixes #12075

Status

Ready

Description

Remove possible extra lines in voms-proxy-info stdout when parsing it. Avoid using | tail Also add messages in case of error and add exception catching

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

overrides https://github.com/dmwm/WMCore/pull/12076

External dependencies / deployment changes

None

cmsdmwmbot commented 2 months ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15169/artifact/artifacts/PullRequestReport.html

belforte commented 2 months ago

I will not try to fix tricky pylint complains about 10+ years old code. Too much risk. All in all at some point this will not be needed anymore.

cmsdmwmbot commented 2 months ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15170/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 2 months ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15171/artifact/artifacts/PullRequestReport.html

belforte commented 2 months ago

tested on crab-dev-tw01, currently deployed on crab-preprod-tw01

amaltaro commented 2 months ago

@belforte once you are happy with your changes, please make a review request through the GitHub interface (right top corner, under Reviewers). For more details, please check out Step 9 under this link: https://github.com/dmwm/WMCore/blob/master/CONTRIBUTING.rst#contributing

belforte commented 2 months ago

and squash commits of course !

belforte commented 2 months ago

running in production TaskWorker since this morning. Let's wait a couple of days

belforte commented 2 months ago

no proxy related errors in CRAB anymore. Finalizing PR

cmsdmwmbot commented 2 months ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15175/artifact/artifacts/PullRequestReport.html

amaltaro commented 2 months ago

@belforte it looks like you have already found 2.3.6rc2 in pypi. I didn't share that with you because our CD pipeline got broken with a recent release, and we have not yet merged that fix in. In any case, that failed only the Docker image creation, which seems irrelevant to you.

belforte commented 2 months ago

We have been running production TW with my branch since more than a week. My branch has the fix on top of what master was few days ago... :man_shrugging: I believe it is good for us :-)