search

dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Fix check for non-stable docker image in the CD pipeline #12088

Closed amaltaro closed 3 weeks ago

amaltaro commented 1 month ago

Fixes https://github.com/dmwm/WMCore/issues/11762 Complement to https://github.com/dmwm/WMCore/pull/12005

Status

ready

Description

As reported in this comment: https://github.com/dmwm/WMCore/pull/12005#issuecomment-2319718816

the latest changes to this CD pipeline are incorrectly skipping the non-stable tag, because the they refer to the same tag.

Explicitly writing -stable in that grep command should solve this problem.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Bug fix for https://github.com/dmwm/WMCore/pull/12005

External dependencies / deployment changes

None

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15177/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15178/artifact/artifacts/PullRequestReport.html

amaltaro commented 3 weeks ago

Unit test failure is completely unrelated (and we have no unit tests for bash scripts). @todor-ivanov @vkuznet if you have a chance today, I would appreciate it if you could review this PR. Thanks

amaltaro commented 3 weeks ago

Thanks Valentin!