dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Fix Pset setup unit tests for Alma9 nodes #12106

Closed khurtado closed 1 month ago

khurtado commented 1 month ago

Fixes #12105

Status

ready

Description

This PR detects the major OS version and make changes accordingly. While this could be made more generic, I don't think we are planning to support RHEL7 anymore, so this is temporary, in order not to break the current RHEL7 jenkins setup.

In addition to that, it uses a method to get the maxEvents input value for some setupCMSSEPset unit tests.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

<Add cvmfs cms environment (needed for CMSSWSetupPset tests)>

External dependencies / deployment changes

Related issue: https://github.com/dmwm/WMCore/issues/11978

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15225/artifact/artifacts/PullRequestReport.html

khurtado commented 1 month ago

@amaltaro I followed your suggestion to detect the OS version and change the scram arch. While this could be made more generic, I don't think we are planning to support RHEL7 anymore, so this is temporary, in order not to break the current RHEL7 jenkins setup

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15226/artifact/artifacts/PullRequestReport.html

khurtado commented 1 month ago

@d-ylee @amaltaro These (and the related PR in the comments) are changes that I needed in order to make SetupCMSSEPSet unit tests work on Alma9. These changes should not break the RHEL7 unit tests.

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15228/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15235/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15236/artifact/artifacts/PullRequestReport.html

khurtado commented 1 month ago

@amaltaro Thanks, I didn't notice the deleted tests, I just fixed this. Please, have another look.

khurtado commented 1 month ago

@amaltaro done!

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15255/artifact/artifacts/PullRequestReport.html

amaltaro commented 1 month ago

Thanks Kenyi!