Exclude RequestStatus from the returned values of get_modifiable_properties

[todor-ivanov]

Fixes #12037

Status

Ready

Description

with the current change we remove the RequestStatus key from the returned values of get_modifiable_properties. this should avoid the conflict created between the set of values checked during the validation and the set of values supported in the WEB interface (the number of visualized keys in the web interface).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

A Fix of a bug eventually introduced with: #12077

External dependencies / deployment changes

No

[todor-ivanov]

@amaltaro I think this may solve the probelm, but I still experience some issues with my dev cluster (communicated in the cmsweb channel), so I am not able to test it yet.

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 7 warnings
  • 53 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 7 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15227/artifact/artifacts/PullRequestReport.html

[todor-ivanov]

Hi @amaltaro I just tested the fix - it's doing the job properly. we can safely merge this one

[amaltaro]

@todor-ivanov it looks like we missed the the failing unit test:

    WMCore_t.ReqMgr_t.Utils_t.Validation_t.ValidationTests:testValidateRequestAllowedArgs changed from success to failure

Please provide a new PR with the relevant fix (fixing the original issue 12107).

[todor-ivanov]

This whole comment here was wrongly posted to the current PR. Now deleted and moved to: https://github.com/dmwm/WMCore/pull/12111#issuecomment-2375128323

[todor-ivanov]

This whole comment here was wrongly posted to the current PR. Now deleted and moved to: https://github.com/dmwm/WMCore/pull/12111#issuecomment-2375130867