search

dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

WMCore setup.py install_system doesn't walk down directories #1213

Closed DMWMBot closed 12 years ago

DMWMBot commented 13 years ago

Starting with WMCORE_0_7_0, {{{ python setup.py build python setup.py install_system -s reqmgr --prefix=install }}}

doesn't install into subdirectories. So WMCore/Agent gets installed, but WMCore/Agent/Daemon doesn't.

Changes to setup_build.py in #1084 seem responsible.

The only workaround I have is to have my builds install the entire WMCore codebase.

{{{ python setup.py install --prefix=install }}}

drsm79 commented 13 years ago

metson: Please Review

drsm79 commented 13 years ago

metson: FWIW you don't need to build then install, you just run {{{ python setup.py install_system -s reqmgr --prefix=install }}}

ghost commented 13 years ago

lat: I was wondering if recursion is actually the desired default behaviour.

For example Diego and I noticed that web stuff installs WMCore.Agent, but not WMCore.Agent.Daemon. We worked on something like Simon's patch here. We then noticed WMCore.Agent contains a lot of stuff, and it's unclear if we actually want to include it into wmcore-web RPMs. Off the hip it seemed we didn't actually want to install all of it.

So how about changing the dependencies to accept some indicator, like prefix or suffix letter '+' to indicate you want recursion? If you say 'WMCore.Agent+', you want fully recursive scan, if you say 'WMCore.Agent' you get just that package?

I am happy to whip up some code for this once there's an agreement how it should work.

drsm79 commented 13 years ago

metson: Yeah, that sounds good. Since I have a patch up already I'm happy to add this in...

drsm79 commented 13 years ago

metson: Please Review

DMWMBot commented 13 years ago

rickw: The patches look good, but I'll need to submit a patch to specify which packages need to have their subdirectories decorated with a '+'.

DMWMBot commented 13 years ago

rickw: Please Review

DMWMBot commented 13 years ago

rickw: Actually, I might as well make sure the WorkQueue dependencies are satisfied, too. I'll submit another patch.

After that, I'll need Team Fermilab to spring into action with the intricate choreography of a ballet company.

Seangchan tests WorkQueue install Dave commits. Steve tags. I build, install at CERN, and add security decorators, test, and submit a patch Steve reviews, commits, and tags again.

evansde77 commented 13 years ago

evansde: I just reviewed and committed the two current patches on this ticket.... can you make sure further patches apply to the head?

DMWMBot commented 13 years ago

rickw: Please Review

evansde77 commented 13 years ago

evansde: Looks good to me, but I would like Seangchan to sign off before committing...

ticoann commented 13 years ago

sryu: Dave, it looks fine to me in WorkQueue side if this is for 0_7_0 not trunk. Also if this is not using the separate GlobalMonitoring application (but works with current RequestOverview) (on RequestMgr dependency)

evansde77 commented 13 years ago

evansde: Committed.... next step in Rick's plan is a tag from Steve...

sfoulkes commented 13 years ago

sfoulkes: I added it to the 0_7_X branch, is a tag on Monday OK?

sfoulkes commented 13 years ago

sfoulkes: WMCORE_0_7_0a, should have everything you need.

drsm79 commented 13 years ago

metson: This should be closed, right?