dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Support SiteList change in ReqMgr - aggregate all PRs #12148

Closed todor-ivanov closed 1 month ago

todor-ivanov commented 1 month ago

Fixes #12037

Status

SUPERSEEDED BY: https://github.com/dmwm/WMCore/pull/12120

Description

SUPERSEDES: https://github.com/dmwm/WMCore/pull/12146

With the current change we allow SiteLists related actions for statuses: staging, acquired, running-open in ReqMgr2

Before making a call to central services for changing any of the request parameters, an additional step is executed to to check which are the allowed parameter modifications for the given status and if the so provided new values from the rest call actually differ from the workflow parameters already defined in central couchdb.

With the current change we no longer ignore all the rest of the request arguments provided with the REST call in the cases of a change of the Request priority. See: https://github.com/dmwm/WMCore/issues/8457#issuecomment-366195086

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

This PR provides a cherry-pick of 3 pull requests that have been recently reverted. Changes have been originally provided by: https://github.com/dmwm/WMCore/pull/12077 https://github.com/dmwm/WMCore/pull/12108 https://github.com/dmwm/WMCore/pull/12111

And on top of them the following one should be rebased: https://github.com/dmwm/WMCore/pull/12120

External dependencies / deployment changes

None

cmsdmwmbot commented 1 month ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15335/artifact/artifacts/PullRequestReport.html

cmsdmwmbot commented 1 month ago

Can one of the admins verify this patch?

todor-ivanov commented 1 month ago

NEVER MERGE

SUPERSEEDED BY: https://github.com/dmwm/WMCore/pull/12120