dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Requestor need possibility to request two-file solution processing #1522

Closed gutsche closed 12 years ago

gutsche commented 13 years ago

Hi,

we need a possibility for the requestor to select two-file processing for a workflow step. It is not enough to just look at the output event contents or data tiers because sometimes the access to RAW and RECO is needed although only RECO is written out (partial re-reconstruction use case).

Thanks,

OLI

sfoulkes commented 13 years ago

sfoulkes: You can already do this if you change the splitting algorithm for the top level task to "TwoFileBased". However, you can't do this when creating the request. That is covered in issue 1223.

gutsche commented 13 years ago

gutsche: I think there is a misunderstanding. How would we know to select the TwoFileBased splitting if nothing in the request would tell us?

OLI

sfoulkes commented 13 years ago

sfoulkes: I assumed the requester would do it. Are you wanting a flag to be set when making the request? That flag could enable the two-file-read processing for the top level task.

gutsche commented 13 years ago

gutsche: Yes, please.

OLI

sfoulkes commented 13 years ago

sfoulkes: (In 12577) Support two file reads in the FileBased, LumiBased and EventBased splitting algorithms. Add a parameters to the ReqMgr to enable two-file-read at the request creation level. Fixes #1225, #1522.

From: Matt Norman mnorman@fnal.gov From: Steve Foulkes sfoulkes@fnal.gov

sfoulkes commented 13 years ago

sfoulkes: (In 99fa045959c5fa42427106d6249453679a20bdea) Support two file reads in the FileBased, LumiBased and EventBased splitting algorithms. Add a parameters to the ReqMgr to enable two-file-read at the request creation level. Fixes #1225, #1522.

From: Matt Norman mnorman@fnal.gov From: Steve Foulkes sfoulkes@fnal.gov

PerilousApricot commented 13 years ago

meloam: This patch has a syntax error:

{{{

Andrew-Melos-MacBook-Pro:GITHUB-WMCORE meloam$ python2.6 src/python/WMComponent/PromptSkimScheduler/PromptSkimPoller.py File "src/python/WMComponent/PromptSkimScheduler/PromptSkimPoller.py", line 165 "ValidStatus": "VALID"} ^ SyntaxError: invalid syntax

}}}

This diff shows where a comma should go:

{{{

diff --git a/src/python/WMComponent/PromptSkimScheduler/PromptSkimPoller.py b/src/python/WMComponent/PromptSkimScheduler/PromptSkimPoller.py index d4a825c..b2c5e66 100644 --- a/src/python/WMComponent/PromptSkimScheduler/PromptSkimPoller.py +++ b/src/python/WMComponent/PromptSkimScheduler/PromptSkimPoller.py @@ -161,7 +161,7 @@ class PromptSkimPoller(BaseWorkerThread): "MaxMergeEvents": self.maxMergeEvents, "StdJobSplitAlgo": "FileBased", "StdJobSplitArgs": {"files_per_job": 1,

}}}