search

dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Fixup WMBS Subscription Types #2349

Closed sfoulkes closed 12 years ago

sfoulkes commented 13 years ago

Two problems: Creating a subscription with an unknown (to WMBS) subscription type fails silently. The new subscription type should just be added to the wmbs_sub_types table.

Secondly, we currently use the taskType as the subscription type. This doesn't work for the MonteCarloFromGEN workflow. It's a processing workflow but needs to run in resource control as "Production". We'll need to support this for the Tier0 as well which will have a bunch of processing workflows that will run as different things in Resource Control (Repack, Reco, Express, etc.)

DMWMBot commented 13 years ago

mnorman: Hopefully this is what you wanted. It introduces into WMTask a new value primarySubtypes which defaults to the taskType if not set, and is called by WMBSHelper.

Unfortunately, the unittest for Subscription ended up in #2343 by accident.

sfoulkes commented 13 years ago

sfoulkes: (In 2767c95607750d99a7eeaa8a1ee4a7fc8593d2aa) Fixup WMBS subscription types. Fixes #2349.

From: Matt Norman mnorman@fnal.gov Signed-off-by: Steve Foulkes sfoulkes@fnal.gov