DBSReader_t should properly bomb if no X509 cert is there

dmwm / WMCore

Core workflow management components for CMS.

Apache License 2.0

46 stars 107 forks source link

DBSReader_t should properly bomb if no X509 cert is there #3517

Closed PerilousApricot closed 12 years ago

PerilousApricot commented 12 years ago

test/python/WMCore_t/Services_t/DBS_t/DBSReader_t.py tries to do the right thing by marking proxy-requiring tests with integration, but the setUp function still tries to use the X509 cert and dies (from instantiating a DBSReader object)

DMWMBot commented 12 years ago

mnorman: Do we have a way to mark an entire unittest as Integration so that it doesn't even load?

Otherwise I think the answer is "Tough luck"

sfoulkes commented 12 years ago

sfoulkes: Move the instantiation of the DBSReader object out of the setUp() method and into the test methods themselves.

DMWMBot commented 12 years ago

mnorman: That's a pretty horrible solution, but so it goes.

sfoulkes commented 12 years ago

sfoulkes: (In 588fc1203991a1996f35b0eda1a2769b39a05dbe) Make the DBSReader unit test fail gracefully if no X509 cert is set. Fixes #3517.

From: Matt Norman mnorman@fnal.gov Signed-off-by: Steve Foulkes sfoulkes@fnal.gov