search

dmwm / WMCore

Core workflow management components for CMS.
Apache License 2.0
46 stars 107 forks source link

Remove legacy crab config from wmagent-mod-config #8926

Closed amaltaro closed 5 years ago

amaltaro commented 5 years ago

@belforte @lecriste can you please confirm whether we can safely remove these sections from this code: https://github.com/dmwm/WMCore/blob/master/bin/wmagent-mod-config#L158-L189

and a few other like CRABInterface and etc? I guess it's no longer used by CRAB, is it?

lecriste commented 5 years ago

@dciangot is working on a new ASO version and may comment more.

belforte commented 5 years ago

I am not capable to say if CRBA uses this file or not. I surely hope not... but, how do I check ? If it were used, it would be part of the rpm build/deploy process which I do not understand. In particular, if this stuff related to ASO (as it looks) , let's keep in mind that ASO still uses an internal CouchDB, even if xfer bookkeeping is done in Orcacle. If this is all for ASO, I'd keep the code even if not used, until we transitoin to ASO_v2 and then scratch it.

amaltaro commented 5 years ago

Leonardo and I had a look at it yesterday and that code dates 6 to 7 years back, so likely when there was the attempt to implement CRAB within WMCore. Since we're doing quite some work on the agent deployment land, I'd actually suggest a different approach. Instead of waiting for a new version of ASO, because we're not sure whether the old/current one uses that code, how about we remove this code and keep an eye whether anything fails? If it does, we rollback that PR and that is it.

I had a quick look at the CRABServer repo and I don't see that wmagent-mod-config being used anywhere, neither most of those config sections.

belforte commented 5 years ago

if you know what to look for, can you check ASO repo in https://github.com/dmwm/AsyncStageout then I am fine with your proposal

amaltaro commented 5 years ago

I was going to ssay that I couldn't find where or how it's actually used, but I do see some sections in the code like this https://github.com/dmwm/AsyncStageout/blob/master/src/python/AsyncStageOut/CleanerDaemon.py#L90

but then looking into the ASO deployment code, there we go: https://github.com/dmwm/deployment/blob/master/asyncstageout/manage#L246

so we cannot delete those (and I was actually removing that amq_auth_file in another PR, so let me get that back into the module).

belforte commented 5 years ago

thanks Alan. Sorry for the trouble. We will try to get rid of this stuff asap.

amaltaro commented 5 years ago

No worries, I don't want to remove code in use. However, it makes me really happy to wipe out all the garbage that is not needed by anyone or not used. Thanks, Stefano. I'm closing this issue.