Add on GE21-M-L1 and GE21-P-L2 plots

dmwm / deployment

CMS DMWM Deployment

19 stars 179 forks source link

Add on GE21-M-L1 and GE21-P-L2 plots #1306

Closed Dongwoon77 closed 7 months ago

Dongwoon77 commented 7 months ago

PR description:

replace GE21-M-L2 with GE21-M-L1
Lumi-based chamber status, OptoHybrid status and VFAT status (chamber vs. VFAT)
Add on GE21-M-L1 recohits occupancy and average cluster plots
Add on GE21-M AMC status plot.

This PR is related to PRs on cms-sw; see
https://github.com/cms-sw/cmssw/pull/41915 (to master)
https://github.com/cms-sw/cmssw/pull/42483 (backport)

arooshap commented 7 months ago

Hi @Dongwoon77,

your changes have been incorporated in HG2402b release and deployed in the testbed VMs. Kindly validate, thanks!

Dongwoon77 commented 7 months ago

Dear @arooshap.

Sure, I'll test it with #1304 PR.

Dongwoon77 commented 6 months ago

Hi @arooshap @nothingface0.

This link is some of the lines matching to GE21-P-L2 module [1]

I didn't edit that, but this lines were pushed back at code so It looks like difference at git-diff.

and no plots for GE21-M-L1 are not implemented in the central P5 DQM currently, but it will be added in the coming runs.

[1] https://github.com/Dongwoon77/deployment/blob/GEMOnlineDQMForFullGE21/dqmgui/layouts/gem-layouts.py#L56-L75

Thank you!

nothingface0 commented 6 months ago

Hi @arooshap @nothingface0.

This link is some of the lines matching to GE21-P-L2 module [1]

I didn't edit that, but this lines were pushed back at code so It looks like difference at git-diff.

and no plots for GE21-M-L1 are not implemented in the central P5 DQM currently, but it will be added in the coming runs.

[1] Dongwoon77/deployment@GEMOnlineDQMForFullGE21/dqmgui/layouts/gem-layouts.py#L56-L75

Thank you!

@Dongwoon77 Just to make sure, this means that this PR is fine as it is for now?

Dongwoon77 commented 6 months ago

@nothingface0

Yep, we have checked that this PR looks fine.

Thank you!