dmwm / deployment

CMS DMWM Deployment
19 stars 179 forks source link

Problem with pep8 in WMAgent Dev #472

Open ericvaandering opened 7 years ago

ericvaandering commented 7 years ago

Hi @BrunoCoimbra @ticoann

When I try to run "pep8" within our deployment I get an error

[dmwm@72d561e8d903 WMCore]$ pep8
bash: /home/dmwm/unittestdeploy/wmagent/1.1.3.pre5/sw/slc6_amd64_gcc493/external/py2-pep8/1.7.0-comp2/bin/pep8: /build/dmwmbld/srv/state/dmwmbld/builds/comp_gcc493/w/slc6_amd64_gcc493/extern: bad interpreter: No such file or directory

This comes from the fact that the python it's trying to use at the start of which pep8 is this:

!/build/dmwmbld/srv/state/dmwmbld/builds/comp_gcc493/w/slc6_amd64_gcc493/external/python/2.7.13/bin/python

If I replace this with the standard /usr/bin/env python , everything is OK. Can you fix the RPMs please?

ticoann commented 7 years ago

@BrunoCoimbra, I am not sure how this line is set in pep8 file (/home/dmwm/unittestdeploy/wmagent/1.1.3.pre5/sw/slc6_amd64_gcc493/external/py2-pep8/1.7.0-comp2/bin/pep8)

#!/build/dmwmbld/srv/state/dmwmbld/builds/comp_gcc493/w/slc6_amd64_gcc493/external/python/2.7.13/bin/python

It looks like this is set set the rpm creation not on deploy creation.

BrunoCoimbra commented 7 years ago

Hi @ericvaandering @ticoann,

Thanks for reporting this issue. I've just included a fix on [1] and Lina is about to deploy it in testbed. For a real test however you should test it on a wmagent since the problem was found there. Could you please deploy it with the latest tag HG1705f and let me know if it works?

[1] https://github.com/cms-sw/cmsdist/commit/5b661f71caa85785084e664a626f7313a1755842

amaltaro commented 7 years ago

Bruno, there is no need to deploy it in testbed, it's not used there anyways.

BrunoCoimbra commented 7 years ago

This tag is going to production on Monday. I agree that it's very unlikely to break anything, but it's better to make sure the fix didn't have any side effects.