search

dmytro-anokhin / url-image

AsyncImage before iOS 15. Lightweight, pure SwiftUI Image view, that displays an image downloaded from URL, with auxiliary views and local cache.
MIT License
1.1k stars 96 forks source link

Change defaultOptions maxPixelSize to nil #116

Closed pballart closed 3 years ago

pballart commented 3 years ago

Is your feature request related to a problem? Please describe. I was investigating why some images were looking bad and then I found out that the default maxPixelSize is set to 300 x 300 px.

Describe the solution you'd like I would like the default to be nil, which would use the original image size. I think it makes more sense specially when getting images served from CDNs and so that usually already come at the correct size for the device.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

dmytro-anokhin commented 3 years ago

Hey,

I won't change it to nil (at least for now) because not everyone is using their own CDN and I want to keep memory footprint low. This is why the property was added in the first place.

However, I would love to hear what is more common size, so I created this issue #117. Please comment there. I will keep in mind your suggestion.

Thank you.