search

dmytro-anokhin / url-image

AsyncImage before iOS 15. Lightweight, pure SwiftUI Image view, that displays an image downloaded from URL, with auxiliary views and local cache.
MIT License
1.1k stars 96 forks source link

Carthage support #140

Closed Lavmint closed 3 years ago

Lavmint commented 3 years ago

Is your feature request related to a problem? Please describe. Carthage is not supported. By now Carthage expects *.xcodeproj to be presented in root folder

Describe the solution you'd like Generate xcodeproj with swift package generate-xcodeproj and commit to git

Describe alternatives you've considered SwiftPM and cocoapods but they are not building dependencies as binary

Additional context none

jrtibbetts commented 3 years ago

There's no compelling reason to add Carthage support to an existing Swift Package. But if it's as simple as generating a project file from the Package file, then you can fork the repo, generate it, and open a PR.

dmytro-anokhin commented 3 years ago

Hey,

unfortunately it is not that simple. This is another step in release process to maintain. Considering that there is no CI for the package, it is also manual. Carthage is no the tool I'm familiar with, but experience shows: things break and need to be tested.

Sorry, but until I set up proper CI, it's a no.

Lavmint commented 3 years ago

Hey,

unfortunately it is not that simple. This is another step in release process to maintain. Considering that there is no CI for the package, it is also manual. Carthage is no the tool I'm familiar with, but experience shows: things break and need to be tested.

Sorry, but until I set up proper CI, it's a no.

There is no need for CI, I've created PR as was suggested by @jrtibbetts

dmytro-anokhin commented 3 years ago

I appreciate the effort, but no need to create a PR.