search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Implement Ties struct #100

Closed DJBen closed 4 years ago

DJBen commented 4 years ago

Solves #42

codecov-io commented 4 years ago

Codecov Report

Merging #100 into latest will increase coverage by 0.35%. The diff coverage is 70.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #100      +/-   ##
==========================================
+ Coverage   43.78%   44.14%   +0.35%     
==========================================
  Files          46       47       +1     
  Lines        1320     1323       +3     
==========================================
+ Hits          578      584       +6     
+ Misses        742      739       -3
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Ties.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/Note.swift 70.9% <56.52%> (+6.62%) :arrow_up:
...es/MusicXML/Complex Types/PitchUnpitchedRest.swift 41.17% <80%> (-17.92%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d2be50...6ba8d29. Read the comment docs.

DJBen commented 4 years ago

@jsbean Hi I updated the pull request. Would you able to take another look? Thanks

jsbean commented 4 years ago

Sorry, was packed today, will merge this tomorrow morning!

jsbean commented 4 years ago

This is great. Thanks, @DJBen!